Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineLexer Type should be deleted #1862

Closed
upupming opened this issue Dec 5, 2020 · 2 comments
Closed

InlineLexer Type should be deleted #1862

upupming opened this issue Dec 5, 2020 · 2 comments

Comments

@upupming
Copy link

upupming commented Dec 5, 2020

The InlineLexer doesn't exist anymore, probably we should change this file: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/marked/index.d.ts#L121

I have rebased and implemented option 2 from #1627 (comment)

It didn't make sense to keep the InlineLexer so I just merged it into the Lexer

Hi, since the InlineLexer class has been deleted, can you delete the type definitions in @types/marked too, thanks!
image

Originally posted by @upupming in #1627 (comment)

@UziTech
Copy link
Member

UziTech commented Dec 5, 2020

This issue should be moved to the https://github.com/DefinitelyTyped/DefinitelyTyped repo.

@UziTech UziTech closed this as completed Dec 5, 2020
@upupming
Copy link
Author

upupming commented Dec 5, 2020

@UziTech Thanks for the suggestion, it seems the @types/marked is contributed by different users, so I should change the file by myself and make a PR to their repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants