Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

em and strong (***〜***) #1860

Closed
ghost opened this issue Dec 4, 2020 · 6 comments · Fixed by #1864
Closed

em and strong (***〜***) #1860

ghost opened this issue Dec 4, 2020 · 6 comments · Fixed by #1864
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue released

Comments

@ghost
Copy link

ghost commented Dec 4, 2020

Thanks for the great project.

When em and strong are used together, there appears to be a difference in the analysis results.
At the beginning of a line, em and strong are parsed properly, but in a sentence, they are not.
Is this as expected? We would be happy to confirm it when you have time.

The following link is for your reference.

https://marked.js.org/demo/?text=AAAAAAAA***AA***AAAA%0A%0A***AA***AAAAAAAAAAAA%0A%0A***AA***AAAAAA***AAA***AAA%0A&options=%7B%0A%20%22baseUrl%22%3A%20null%2C%0A%20%22breaks%22%3A%20false%2C%0A%20%22gfm%22%3A%20true%2C%0A%20%22headerIds%22%3A%20true%2C%0A%20%22headerPrefix%22%3A%20%22%22%2C%0A%20%22highlight%22%3A%20null%2C%0A%20%22langPrefix%22%3A%20%22language-%22%2C%0A%20%22mangle%22%3A%20true%2C%0A%20%22pedantic%22%3A%20false%2C%0A%20%22sanitize%22%3A%20false%2C%0A%20%22sanitizer%22%3A%20null%2C%0A%20%22silent%22%3A%20false%2C%0A%20%22smartLists%22%3A%20false%2C%0A%20%22smartypants%22%3A%20false%2C%0A%20%22tokenizer%22%3A%20null%2C%0A%20%22walkTokens%22%3A%20null%2C%0A%20%22xhtml%22%3A%20false%0A%7D&version=master
@UziTech UziTech added category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue labels Dec 4, 2020
@UziTech
Copy link
Member

UziTech commented Dec 4, 2020

looks like this was broken in #1686 it works in v1.1.0

CommonMark demo
Marked v1.1.0 demo
Marked v1.1.1 demo

@calculuschild
Copy link
Contributor

calculuschild commented Dec 4, 2020 •
edited

@UziTech Looks like this is covered by GFM Example 425 which isn't in our test specs. It looks like the GFM spec has been updated somewhat since the original test cases were made (many of the example numbers no longer match). Do we also want to update those tests now to help avoid more regressions like this?

@UziTech
Copy link
Member

UziTech commented Dec 4, 2020

@calculuschild this is covered by CommonMark example 415

It was marked as shouldFail because v1.1.0 had strong and em tags switched so it technically wasn't passing in v1.1.0 but the result in the browser was the same.

@calculuschild
Copy link
Contributor

Alright. I'm looking into this.

@calculuschild
Copy link
Contributor

calculuschild commented Dec 6, 2020 •
edited

Got a working solution. Just need to clean it up a bit and I'll post a PR.

@calculuschild calculuschild mentioned this issue Dec 7, 2020
Merged
5 tasks
@github-actions
Copy link

github-actions bot commented Feb 7, 2021

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Total rework of Emphasis/Strong calculuschild/marked
2 participants
@UziTech @calculuschild