fix: fix atx heading and make regex safe #1853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: v1.2.5
Description
Make heading regex safe from redos and pass all atx heading spec tests.
fixes CommonMark spec test 49
possible breaking change: When using the block.heading rule the text provided in capture group 2 will not be trimmed of whitespace.
Since this is only a breaking change to the capture groups this doesn't require a major release but the previous statement should be copied to the release notes.
Contributor
Committer
In most cases, this should be a different person than the contributor.