Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single emphasis on comments is not consistent with double emphasis #1679

Closed
goodhoko opened this issue May 18, 2020 · 3 comments
Closed

Single emphasis on comments is not consistent with double emphasis #1679

goodhoko opened this issue May 18, 2020 · 3 comments
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue

Comments

@goodhoko
Copy link

Describe the bug
Wrapping a <!-- --> comment in single _ or * emphasis is not consistent with wrapping a comment in double __ or ** emphasis.

To Reproduce

md html
_<!-- foo -->_ _<!-- foo -->_
*<!-- foo -->* *<!-- foo -->*
__<!-- foo -->__ <strong><!-- foo --></strong>
**<!-- foo -->** <strong><!-- foo --></strong>
  1. Marked Demo
  2. CommonMark Demo (they actually got it right)

Expected behavior

md html
_<!-- foo -->_ <em><!-- foo --></em>
*<!-- foo -->* <em><!-- foo --></em>
__<!-- foo -->__ <strong><!-- foo --></strong>
**<!-- foo -->** <strong><!-- foo --></strong>
@UziTech UziTech added category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue labels May 18, 2020
@calculuschild
Copy link
Contributor

I believe this is fixed by #1686

@UziTech
Copy link
Member

UziTech commented Jul 14, 2020

Should be fixed with marked v1.1.1 🎉

@UziTech UziTech closed this as completed Jul 14, 2020
@goodhoko
Copy link
Author

@UziTech I can confirm. Thanks a lot! 👍 🖤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@UziTech @calculuschild @goodhoko