Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loose task list with no tokens #1674

Merged
merged 1 commit into from May 12, 2020
Merged

fix loose task list with no tokens #1674

merged 1 commit into from May 12, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented May 12, 2020

Marked version: 1.0.0

Markdown flavor: GitHub Flavored Markdown

Description

Fix loose task list when task item has no text.

demo

Contributor

  • Test(s) exist to ensure functionality and minimize regression.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented May 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/e5nqmxelz
✅ Preview: https://markedjs-git-fork-uzitech-task-no-tokens.markedjs.now.sh

@joshbruce
Copy link
Member

Sidenote: Feel like we changed the WIP solution - I like it better, but not sure what we're doing there now. lol

@styfle
Copy link
Member

styfle commented May 12, 2020

@joshbruce GitHub has the concept of Draft PR's which is basically WIP https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@styfle styfle merged commit cec5f5e into markedjs:master May 12, 2020
@UziTech UziTech mentioned this pull request May 16, 2020
12 tasks
@UziTech UziTech deleted the task-no-tokens branch June 17, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when rendering an empty checkbox list item
3 participants