Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken <strong> after <em> #1666

Closed
zemlanin opened this issue May 7, 2020 · 3 comments
Closed

Broken <strong> after <em> #1666

zemlanin opened this issue May 7, 2020 · 3 comments
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue

Comments

@zemlanin
Copy link

zemlanin commented May 7, 2020

Describe the bug
Update to 1.0.0 broke the case of "emphasis, followed by punctuation, followed by strong" if both emphasis and strong are marked by asterisks

For example, *em*-**strong** in 0.8.2 correctly rendered <p><em>em</em>-<strong>strong</strong></p>, while 1.0.0 renders <p><em>em<em>-**strong</em></em></p>

To Reproduce
Steps to reproduce the behavior:

  1. Marked Demo
  2. CommonMark Demo

Expected behavior
*em*-**strong** should render <p><em>em</em>-<strong>strong</strong></p>

@UziTech UziTech added category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue labels May 7, 2020
@calculuschild
Copy link
Contributor

I believe this is fixed now by #1686

@UziTech
Copy link
Member

UziTech commented Jul 13, 2020

We will release a new version of marked soon with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: inline elements L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Development

No branches or pull requests

3 participants