Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add browser field to point to es5 #1661

Merged
merged 1 commit into from May 4, 2020
Merged

add browser field to point to es5 #1661

merged 1 commit into from May 4, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented May 2, 2020 •
edited by styfle

Marked version: 1.0.0

Description

Add browser field to package.json that points to lib/marked.js so webpack will use es5 version to bundle for browsers.

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented May 2, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/ju4wzqb8l
✅ Preview: https://markedjs-git-fork-uzitech-browser-field.markedjs.now.sh

styfle
styfle approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this will fix some users and break others, but lets give it a shot 😅

@styfle styfle merged commit a1679fa into markedjs:master May 4, 2020
@drandell drandell mentioned this pull request May 5, 2020
Closed
This was referenced May 16, 2020
Merged
Closed
@UziTech UziTech deleted the browser-field branch June 17, 2020 17:54
@boazy boazy mentioned this pull request Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@joshbruce joshbruce joshbruce approved these changes

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add browser field to package.json
3 participants
@UziTech @styfle @joshbruce