Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix underscore emphasis then comma #1660

Merged
merged 1 commit into from May 4, 2020
Merged

fix underscore emphasis then comma #1660

merged 1 commit into from May 4, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented May 2, 2020

Marked version: 1.0.0

Description

Fix regression when comma is after underscore emphasis

CommonMark Demo
Marked Demo, version 1.0.0 doesn’t work
Marked Demo, version 0.8.2 works

Fixes #1659

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented May 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/ju4wzqb8l
✅ Preview: https://markedjs-git-fork-uzitech-fix-em-comma.markedjs.now.sh

@UziTech UziTech merged commit a220ce9 into markedjs:master May 4, 2020
@UziTech UziTech deleted the fix-em-comma branch May 4, 2020 15:45
@UziTech UziTech mentioned this pull request May 16, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underscores don’t turn into emphasis on 1.0.0
3 participants