-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Intra-word emphasis can match the wrong asterisks #1636
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/markedjs/markedjs/qba5ws1f2 |
@davisjam could you check if the new regex is vulnerable to ReDos? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't looks like this changes the structure of the regex so if it wasn't vulnerable before than it shouldn't be now.
Good work! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fix: Intra-word emphasis can match the wrong asterisks
fix: Intra-word emphasis can match the wrong asterisks
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.