Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star italics are mishandled around text in double quotes #1629

Closed
octogonz opened this issue Mar 25, 2020 · 1 comment
Closed

Star italics are mishandled around text in double quotes #1629

octogonz opened this issue Mar 25, 2020 · 1 comment

Comments

@octogonz
Copy link
Contributor

octogonz commented Mar 25, 2020

Describe the bug

CommonMark allows the * character to be used to italicize text. Marked supports this, but not when the text contains double quotes.

To Reproduce

Consider this markdown input:

1. *"hello"* - INCORRECT
2. *"hello* - INCORRECT
3. *hello"* - correct
4. _"Hello"_ - correct
5. *'hello'* - correct
6. **"hello"** - correct

Marked Demo renders the first two strings incorrectly.

Expected behavior

CommonMark Demo renders it correctly: Items 1 through 5 are italicized, and item 6 is boldfaced.

@UziTech
Copy link
Member

UziTech commented Mar 26, 2020

duplicate of #1358

@UziTech UziTech closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants