Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove module field #1581

Merged
merged 1 commit into from Dec 12, 2019
Merged

remove module field #1581

merged 1 commit into from Dec 12, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Dec 12, 2019

Marked version: master

Description

remove module field in package.json

see discussion #1571 (comment)

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Dec 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/ljo0sjr1f
🌍 Preview: https://markedjs-git-fork-uzitech-module-field.markedjs.now.sh

@UziTech
Copy link
Member Author

UziTech commented Dec 12, 2019

I also updated devdependencies

@joshbruce joshbruce merged commit c3ac5e1 into markedjs:master Dec 12, 2019
@UziTech UziTech mentioned this pull request Dec 12, 2019
12 tasks
@UziTech UziTech deleted the module-field branch December 12, 2019 21:24
This was referenced Dec 20, 2019
This was referenced Apr 22, 2020
@UziTech UziTech mentioned this pull request Apr 20, 2021
5 tasks
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
remove module field - May want to double check that this is in the correct place in the release notes. I put it under fix based one the discussion linked above and added a note re updating the dev dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants