Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build user #1577

Merged
merged 1 commit into from Dec 12, 2019
Merged

fix build user #1577

merged 1 commit into from Dec 12, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Dec 6, 2019

Description

I think this will fix the wrong user showing up as the committer for the build step on travis ci.

image

<> is used to indicate no email address according to stackoverflow.

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Dec 6, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/9i6x7zwel
🌍 Preview: https://markedjs-git-fork-uzitech-build-user.markedjs.now.sh

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👍

@UziTech
Copy link
Member Author

UziTech commented Dec 12, 2019

I'm going to merge this even though we don't have two approvals since it doesn't affect the end user.

@UziTech UziTech merged commit 45a9c4a into markedjs:master Dec 12, 2019
@UziTech UziTech deleted the build-user branch December 12, 2019 16:29
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants