Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changing global defaults #1576

Merged
merged 2 commits into from Dec 5, 2019
Merged

fix changing global defaults #1576

merged 2 commits into from Dec 5, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Dec 5, 2019

Marked version: master

Description

fix regression in setOptions being global

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Dec 5, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/markedjs/markedjs/d23zmogda
🌍 Preview: https://markedjs-git-fork-uzitech-fix-defaults.markedjs.now.sh

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@UziTech UziTech merged commit ef7fa93 into markedjs:master Dec 5, 2019
@UziTech UziTech deleted the fix-defaults branch December 5, 2019 23:03
@UziTech UziTech mentioned this pull request Dec 5, 2019
12 tasks
This was referenced Dec 20, 2019
This was referenced Apr 22, 2020
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
fix changing global defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants