relative baseUrl

[UziTech]

Marked version: master

Description

Allow baseUrl option to be a relative url.

• Closes Remove baseUrl if its just a slash #1513
• Fixes baseUrl with relative prefix not working as expected. #1466

Expectation

<p><img src="/favicon.ico" alt="alt text" title="relative"></p>

Result

<p><img src="/derp//favicon.ico" alt="alt text" title="relative"></p>

What was attempted

marked('![alt text](/favicon.ico "relative")', {baseUrl: "/derp/"});

Contributor

• Test(s) exist to ensure functionality and minimize regression.
• If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

• Draft GitHub release notes have been updated.
• CI is green (no forced merge required).
• Merge PR

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://markedjs-git-fork-uzitech-baseurl-null.markedjs.now.sh

[davisjam]

Looks OK from a regex perspective.

[EdwardEisenhauer]

Hello,

is there a way to turn off this behaviour via options? I have a lot of relative links in my markdown files, which come from the external (not the one in which marked is used) website.

[UziTech]

@EdwardEisenhauer baseUrl is null by default.

[EdwardEisenhauer]

@EdwardEisenhauer baseUrl is null by default.

after setting baseURL via:

marked.setOptions({
	baseUrl: 'https://external.domain/some/path/',
});

when using:

marked('[some_link](/i/want/to/go/there)');

I receive:

"<p><a href=\"https://external.domain/i/want/to/go/there\">some_link</a></p>"

when I would like to get:

"<p><a href=\"https://external.domain/some/path/i/want/to/go/there\">some_link</a></p>"

as if calling:

marked('[some_link](i/want/to/go/there)');

I would like to be able to turn off relative link generation if there is a leading slash.

[UziTech]

@EdwardEisenhauer your best bet would be to walk the tokens and update the href

marked.use({
  walkTokens(token) {
    if (token.type === 'link') {
      token.href = 'https://external.domain/some/path' + token.href;
    }
  }
});
marked('[some_link](/i/want/to/go/there)');

https://runkit.com/embed/rmsje9r0y7cy

[EdwardEisenhauer]

@UziTech I modified it to:

if (token.type === 'link' && token.href[0] === '/') {
    token.href = 'https://external.domain/some/path' + token.href;
}

And now it works as expected (as I have some links to the external webpages too). Thanks for help!