Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested blockquotes #1464

Merged
merged 4 commits into from May 3, 2019
Merged

Nested blockquotes #1464

merged 4 commits into from May 3, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Apr 9, 2019 •
edited by joshbruce

Marked version: master

Markdown flavor: All

Description

Removes recursion for nested blockquotes

Fixes #1462 demo

TODO:

  • clean up code
  • add more tests

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech mentioned this pull request Apr 9, 2019
Closed
@UziTech UziTech changed the title [WIP] Nested blockquotes Nested blockquotes Apr 12, 2019
@styfle
Copy link
Member

styfle commented Apr 18, 2019

@UziTech Are these todo's still relevant?

  • clean up code
  • add more tests

@UziTech
Copy link
Member Author

UziTech commented Apr 18, 2019

Sorry no, I forgot to check them.

@styfle styfle added category: blockquotes L0 - security A security vulnerability within the Marked library is discovered labels Apr 18, 2019
@UziTech UziTech closed this Apr 25, 2019
@UziTech UziTech deleted the nested-blockquotes branch April 25, 2019 05:11
@UziTech UziTech restored the nested-blockquotes branch May 3, 2019 19:54
@UziTech UziTech reopened this May 3, 2019
@UziTech
Copy link
Member Author

UziTech commented May 3, 2019

I'm not sure why I closed this before. This should be ready to merge.

/cc @styfle @joshbruce @davisjam

@joshbruce joshbruce merged commit 67b91cf into markedjs:master May 3, 2019
@andersk andersk mentioned this pull request May 3, 2019
Closed
This was referenced Jun 4, 2019
Closed
Merged
joshbruce added a commit that referenced this pull request Jun 12, 2019
@joshbruce
Merge pull request #1497 from UziTech/revert-1464
5ba9ba5 
revert #1464
@UziTech UziTech deleted the nested-blockquotes branch July 1, 2019 18:08
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Apr 24, 2020
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 6, 2020
Open
This was referenced Mar 11, 2021
Merged
Closed
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@joshbruce
Merge pull request markedjs#1464 from UziTech/nested-blockquotes
7cb0be8 
Nested blockquotes
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@UziTech
revert markedjs#1464
0b3be63
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@joshbruce
Merge pull request markedjs#1497 from UziTech/revert-1464
0cc0688 
revert markedjs#1464
@ekmixon ekmixon mentioned this pull request Aug 1, 2022
Open
@hubertczarnowskipracuj hubertczarnowskipracuj mentioned this pull request Aug 4, 2023
Open
@SnykHWilson SnykHWilson mentioned this pull request Oct 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@joshbruce joshbruce joshbruce approved these changes

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
category: blockquotes L0 - security A security vulnerability within the Marked library is discovered
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

marked(">".repeat(5000)) crashes with recursion error
3 participants
@UziTech @styfle @joshbruce