Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links parens #1435

Merged
merged 2 commits into from Mar 8, 2019
Merged

Links parens #1435

merged 2 commits into from Mar 8, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 6, 2019 •
edited by joshbruce

Marked version: master

Markdown flavor: CommonMark

Description

fixes text in parenthesis after link being added as title.

marked demo
commonmark demo

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR)

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech mentioned this pull request Mar 6, 2019
Closed
ghost
ghost approved these changes Mar 6, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, a quick fixture.

styfle
styfle approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@joshbruce joshbruce merged commit b5fb988 into markedjs:master Mar 8, 2019
@UziTech UziTech deleted the links-parens branch March 12, 2019 17:05
@UziTech UziTech mentioned this pull request Mar 14, 2019
Closed
@styfle styfle mentioned this pull request Mar 25, 2019
Merged
12 tasks
@UziTech UziTech mentioned this pull request Mar 29, 2019
Closed
@tmorehouse tmorehouse mentioned this pull request Jun 30, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Open
Closed
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2019
Open
This was referenced Nov 18, 2019
Open
Open
Open
Open
This was referenced Apr 21, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 29, 2020
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Closed
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@joshbruce
Merge pull request markedjs#1435 from UziTech/links-parens
556113a 
Links parens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@davisjam davisjam Awaiting requested review from davisjam

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] We have to use '\' to add the '('
3 participants
@UziTech @styfle @joshbruce