Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty list items #1395

Merged
merged 1 commit into from Dec 20, 2018
Merged

Fix empty list items #1395

merged 1 commit into from Dec 20, 2018

Conversation

mccraveiro
Copy link
Contributor

@mccraveiro mccraveiro commented Dec 19, 2018

Marked version: master branch

Markdown flavor: CommonMark

Description

Input

- foo
-
- bar

Expectation

<ul>
<li>foo</li>
<li></li>
<li>bar</li>
</ul>

Result

<ul>
<li>foo
-</li>
<li>bar</li>
</ul>

What was attempted

Fix empty list items by making white space optional

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@styfle styfle merged commit e5e5b09 into markedjs:master Dec 20, 2018
@mccraveiro mccraveiro deleted the empty-list branch December 20, 2018 21:28
This was referenced Apr 21, 2020
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants