Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit ordered list marker length #1391

Merged
merged 1 commit into from Dec 18, 2018
Merged

Limit ordered list marker length #1391

merged 1 commit into from Dec 18, 2018

Conversation

mccraveiro
Copy link
Contributor

@mccraveiro mccraveiro commented Dec 17, 2018 •
edited by styfle

Marked version: master

Markdown flavor: CommonMark

Description

Expectation

<p>1234567890. not ok</p>

Result

<ol start="1234567890">
<li>not ok</li>
</ol>

What was attempted

Limited ordered list marker length

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

styfle
styfle approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@styfle styfle merged commit 82ace24 into markedjs:master Dec 18, 2018
@mccraveiro mccraveiro deleted the ordered-list branch December 18, 2018 15:05
@UziTech UziTech mentioned this pull request Dec 18, 2018
Merged
4 tasks
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Closed
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2019
Open
This was referenced Nov 18, 2019
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 21, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 28, 2020
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 6, 2020
Open
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@styfle
Merge pull request markedjs#1391 from mccraveiro/ordered-list
7b3eedf 
Limit ordered list marker length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

@styfle styfle styfle approved these changes

@macabeus macabeus macabeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mccraveiro @UziTech @styfle @macabeus