Fix bold around autolink email address #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Dec 6, 2018
UziTech
requested changes
Dec 6, 2018
|
Done 👌 |
UziTech
approved these changes
Dec 6, 2018
styfle
changed the title
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
This was referenced Apr 21, 2020
This was referenced Apr 28, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
Fix bold around autolink email address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: v0.5.2 (revision ed64407)
Markdown flavor: n/a
Description
__test@test.com__This PR fixes a bug of parsing order which can lead autolink to take over parsing of other elements (e.g. bolding). Please look carefully before merging this PR: I obviously ran tests and added a new one, but this is probably a breaking change.
Also, my test should probably not be there, so please feel free to edit (I allowed edit from maintainers)(this has been fixed, c.f. my force push).Expectation
<p><strong><a href="mailto:test@test.com">test@test.com</a></strong></p>Result
<p><a href="mailto:__test@test.co">__test@test.co</a>m__</p>What was attempted
Reordering of parsing (autolink processing now just before text).
Contributor
Committer