Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent application of tildes + great combo badge #1230

Closed
joshbruce opened this issue Apr 18, 2018 · 3 comments
Closed

Inconsistent application of tildes + great combo badge #1230

joshbruce opened this issue Apr 18, 2018 · 3 comments

Comments

@joshbruce
Copy link
Member

joshbruce commented Apr 18, 2018

Marked version: 0.3.19

Markdown flavor: n/a

Proposal type: other

What pain point are you perceiving?

Working through #1229 and saw something interesting.

What solution are you suggesting?

CommonMark: The examples from the fenced code blocks section using tildes (~) should pass...89, for example.

GFM: All three of the examples in the strikethrough section should pass...at present, only two do.

/test/new/gfm_del: This is a test in the current test bed. It passes. Therefore, some of the logic, at least for strikethrough is in place.

That's what makes this a "great combo" and badge worthy. Similar patterns, resulting in different output, across multiple specifications, and, in theory, there's already groundwork in place. To earn the badge submit a PR that allows us to:

  1. Deprecate /test/new/gfm_del.
  2. Pass all failing tests in GFM.
  3. Pass the failing tests in CommonMark that use the tilde.

Just like most fighting games, there will probably be a multiplier depending on what all is hit.

See also #1216

@StephenHogsten
Copy link
Contributor

It looks like the GFM issues were solved in PR #1258 and the last CommonMark issues with code fences were solved in PR #1387

@styfle
Copy link
Member

styfle commented Dec 16, 2018

@joshbruce Should the badge be awarded to 3 people? There were 3 PRs to compelete this so it’s not really a “combo” by one person but a combo by many people.

@joshbruce
Copy link
Member Author

@styfle Sorry, my email rules were not setup in their entirety and I'm catching up. I think the badge can go to all three. Glad to see progress was made!

Many thanks to all who helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants