Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.18 #1152

Merged
merged 2 commits into from Mar 22, 2018
Merged

Release 0.3.18 #1152

merged 2 commits into from Mar 22, 2018

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented Mar 22, 2018

Publisher

  • $ npm version has been run.
  • Release notes in draft GitHub release are up to date
  • Release notes include which flavors and versions of Markdown are supported by this release
  • Committer checklist is complete.
  • Merge PR.
  • Publish GitHub release using master with correct version number.
  • $ npm publish has been run.
  • Create draft GitHub release to prepare next release.

Note: If merges to master occur after submitting this PR and before running $ npm pubish you should be able to

  1. pull from upstream/master (git pull upstream master) into the branch holding this version,
  2. run $ npm run build to regenerate the min file, and
  3. commit and push the updated changes.

Committer

In most cases, this should be someone different than the publisher.

  • Version in package.json has been updated (see PUBLISHING.md).
  • The marked.min.js has been updated; or,
  • release does not change library.
  • CI is green (no forced merge required).

@joshbruce joshbruce requested a review from UziTech March 22, 2018 16:30
@joshbruce
Copy link
Member Author

Not sure why the minified version didn't update. Are we running npm run build somewhere that I maybe misplaced??

@joshbruce joshbruce changed the title 0.3.18 Release 0.3.18 Mar 22, 2018
@joshbruce joshbruce requested a review from styfle March 22, 2018 16:36
@styfle
Copy link
Member

styfle commented Mar 22, 2018

The last commit already updated the minified file. See the history

@joshbruce joshbruce merged commit c1e19a9 into markedjs:master Mar 22, 2018
@joshbruce joshbruce deleted the release-0.3.18 branch March 22, 2018 17:02
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants