Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marked mark maker badge #1147

Merged
merged 6 commits into from Mar 21, 2018
Merged

Add marked mark maker badge #1147

merged 6 commits into from Mar 21, 2018

Conversation

joshbruce
Copy link
Member

Marked version: 0.3.17

Markdown flavor: n/a

Description

Adds Maker of the Marked mark badge

Contributor

  • Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styfle
Copy link
Member

styfle commented Mar 20, 2018

@joshbruce Before you go changing the docs, can we land #1138 first?

@joshbruce
Copy link
Member Author

Good question. Yes.

I was only adding runway to let you run with it by making putting up for being an admin...I don’t think anyone would be opposed to you being the second admin.

Leave it to the team on this one.

@joshbruce
Copy link
Member Author

The next PR I submit will be take move you to admin and let everyone review.

@styfle
Copy link
Member

styfle commented Mar 20, 2018

Ok I merged #1138 and this created merged conflicts with your PR as I expected.

@joshbruce
Copy link
Member Author

joshbruce commented Mar 21, 2018

@UziTech and @styfle: Think I resolved this properly.

@joshbruce
Copy link
Member Author

@markedjs/marked: Merging to move forward on community building todo list.

@joshbruce joshbruce merged commit f886f40 into markedjs:master Mar 21, 2018
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants