fix tables with empty cells at beginning #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notslang
force-pushed
the
tables-with-empty-cells
branch
from
5451de6
to
faf0fb1
Compare
(and add supporting test case)
notslang
force-pushed
the
tables-with-empty-cells
branch
from
faf0fb1
to
86eea8c
Compare
|
LGTM. /cc @rlidwka take a look please. |
|
@slang800 , this commit seem to be causing trouble for indented tables, see #325 . So I reverted it in master, not released yet. Please tell me if you have a better idea to solve it, or if there's any code that depends on this feature. Also, behavior is different from github, if you copy&paste test here in comments for example, last line will fail to render. It's still possible to allow empty leading rows in some corner cases, but I'm not sure it's worth breaking compatibility with github in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a subset of the commits from #223 that aren't controversial