Skip to content

url with !!! is not detected correctly #54

Closed

Activity

puzrin

puzrin commented on Jun 22, 2017

@puzrin
Member

Interesting case. Isn't it too specific? As far as i understand, you can define anything in mailbox label.

jarindr

jarindr commented on Jun 22, 2017

@jarindr
Author

@puzrin you are right, but exclamation mark is something we don't actually need to have a pattern to avoid it?

puzrin

puzrin commented on Jun 22, 2017

@puzrin
Member

Go to http://this.link!!! - !!! should be excluded

puzrin

puzrin commented on Jun 22, 2017

@puzrin
Member

There are condition for ! https://github.com/markdown-it/linkify-it/blob/2.0.3/lib/re.js#L71 (and tests), but those do not cover your case.

reopened this on May 19, 2020
puzrin

puzrin commented on May 19, 2020

@puzrin
Member

Sorry, reverted fix due collision. See commited sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @puzrin@jarindr

        Issue actions

          url with !!! is not detected correctly · Issue #54 · markdown-it/linkify-it