Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lastfm): fix auth callback param #456

Merged
merged 2 commits into from May 9, 2022
Merged

fix(lastfm): fix auth callback param #456

merged 2 commits into from May 9, 2022

Conversation

jackmerrill
Copy link
Contributor

  • Fixes callback url by changing "callback" to "cb"
  • Uses ".com" English website

@jackmerrill
fix(lastfm): fix auth callback param
ce69e1d 
- Fixes callback url by changing "callback" to "cb"
- Uses ".com" English website
@techknowlogick
Copy link
Collaborator

Thanks for the PR Jack :)

Could you update the tests as well?

@jackmerrill
Copy link
Contributor Author

Thanks for the PR Jack :)

Could you update the tests as well?

I just did! Sorry 'bout that haha.

@techknowlogick techknowlogick merged commit 644eeb5 into markbates:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackmerrill @techknowlogick