openidconnect: allow overriding redirect_uri and passing code_verifier #474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #459 this PR extends openidconnect provider's
Session.Authorize
to allow passage ofredirect_uri
andcode_verifier
params.Gitea will need these in order to enable support for PKCE in openidconnect. (See go-gitea/gitea#21376)
It is likely that other providers will also need the addition of PKCE support however, the design of this may need some more thought.
Fix #473
Signed-off-by: Andrew Thornton art27@cantab.net