fix(discord): prompt only if permissions have changed #469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Discord oauth2 flow does not provide a
prompt
GET parameter during the redirect to Discord. As such, the default flow for Discord is to always prompt to validate the flow, even if the user has already previously approved the provided scopes. This PR ensures thatprompt=none
is provided, so Discord will only require a re-prompt if permissions have changed, or if there are elevated permissions being requested.I.e:
bot
&webhook.incoming
) are used, ignoreprompt
parameter, and provide consent dialog.Should be a non-breaking change.