Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

connectTimeout is hardcoded to 1 minute #43

Closed
slonopotamus opened this issue Sep 26, 2019 · 6 comments · Fixed by #44
Closed

connectTimeout is hardcoded to 1 minute #43

slonopotamus opened this issue Sep 26, 2019 · 6 comments · Fixed by #44
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@slonopotamus
Copy link
Contributor

https://github.com/marcphilipp/nexus-publish-plugin/blob/master/src/main/kotlin/de/marcphilipp/gradle/nexus/internal/NexusClient.kt#L42

I'd either set it to the same value as read/write timeouts or provide a separate option.

@marcphilipp
Copy link
Owner

@slonopotamus Do you have a concrete use case for making this configurable?

@slonopotamus
Copy link
Contributor Author

I'm not sure. Currently, OSS Sonatype Nexus is suffering from severe performance issues and drops connections due to this timeout. If timeout was configurable, I could increase it to see if it helps or not.

@jpoehnelt
Copy link

jpoehnelt commented Sep 26, 2019

I'm not sure. Currently, OSS Sonatype Nexus is suffering from severe performance issues and drops connections due to this timeout. If timeout was configurable, I could increase it to see if it helps or not.

having same issue with this plugin and sonatype, not sure if this is the solution or not

> Task :initializeSonatypeStagingRepository
Task ':initializeSonatypeStagingRepository' is not up-to-date because:
  Task has not declared any outputs despite executing actions.
Creating staging repository for stagingProfileId '224a453b33b7aa'

> Task :initializeSonatypeStagingRepository FAILED
:initializeSonatypeStagingRepository (Thread[Execution worker for ':',5,main]) completed. Took 2 mins 32.293 secs.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':initializeSonatypeStagingRepository'.
> java.net.SocketTimeoutException: timeout

@marcphilipp
Copy link
Owner

Thanks for the info. In that case, I'd suggest that we add a new connectTimeout property to the NexusPublishExtension.

@slonopotamus @jpoehnelt Would one of you be interested in submitting a PR?

@marcphilipp marcphilipp added this to the 0.4.0 milestone Sep 27, 2019
@marcphilipp marcphilipp added the enhancement New feature or request label Sep 27, 2019
@slonopotamus
Copy link
Contributor Author

I'll do that, no problem

slonopotamus added a commit to slonopotamus/nexus-publish-plugin that referenced this issue Sep 27, 2019
slonopotamus added a commit to slonopotamus/nexus-publish-plugin that referenced this issue Sep 27, 2019
@slonopotamus
Copy link
Contributor Author

For the reference, here's Sonatype bugreport about this problem: https://issues.sonatype.org/browse/OSSRH-51875

marcphilipp pushed a commit that referenced this issue Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants