Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run this test suite in cobra's main CI #8

Open
umarcor opened this issue Jul 1, 2021 · 2 comments
Open

Run this test suite in cobra's main CI #8

umarcor opened this issue Jul 1, 2021 · 2 comments

Comments

@umarcor
Copy link

umarcor commented Jul 1, 2021

@marckhouzam shall an step or job be added to the cobra CI for running this test suite? Alternatively, shall a CI workflow be added to this repo?

@marckhouzam
Copy link
Owner

Hi @umarcor. I wouldn't feel comfortable having Cobra's CI depend on the proper functioning of this repo, but I like the idea of the reverse.

Could we setup some trigger to run these tests on a commit to the Cobra repo?

@umarcor
Copy link
Author

umarcor commented Jul 2, 2021

We might make it an allowed to fail step/test, so that it doesn't break cobra's CI, but I get your point anyway.

Could we setup some trigger to run these tests on a commit to the Cobra repo?

Yes. However, for the CI in cobra's repo to trigger an event in this repo, it would need to use a token with write access to this repository. I'm not sure that is worth...

Therefore, I suggest to just schedule the job here to be executed say once a day. Alternatively, the schedule can be set to every few hours, and check whether cobra changed since that last time. Again, I don't think it's really worth.

Other than that, we can have the workflow in this repo allow manual workflow_dispatch. So whenever something is pushed to cobra and you want to have it tested, it's one click or one API call away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants