forked from rubocop/rubocop
-
Notifications
You must be signed in to change notification settings - Fork 1
/
mixin_grouping_spec.rb
269 lines (240 loc) · 7.09 KB
/
mixin_grouping_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::MixinGrouping, :config do
context 'when configured with separated style' do
let(:cop_config) { { 'EnforcedStyle' => 'separated' } }
context 'when using `include`' do
it 'registers an offense for several mixins in one call' do
expect_offense(<<~RUBY)
class Foo
include Bar, Qux
^^^^^^^^^^^^^^^^ Put `include` mixins in separate statements.
end
RUBY
expect_correction(<<~RUBY)
class Foo
include Qux
include Bar
end
RUBY
end
it 'allows include call as an argument to another method' do
expect_no_offenses('expect(foo).to include { { bar: baz } }')
end
it 'registers an offense for several mixins in separate calls' do
expect_offense(<<~RUBY)
class Foo
include Bar, Baz
^^^^^^^^^^^^^^^^ Put `include` mixins in separate statements.
include Qux
end
RUBY
expect_correction(<<~RUBY)
class Foo
include Baz
include Bar
include Qux
end
RUBY
end
end
context 'when using `extend`' do
it 'registers an offense for several mixins in one call' do
expect_offense(<<~RUBY)
class Foo
extend Bar, Qux
^^^^^^^^^^^^^^^ Put `extend` mixins in separate statements.
end
RUBY
expect_correction(<<~RUBY)
class Foo
extend Qux
extend Bar
end
RUBY
end
end
context 'when using `prepend`' do
it 'registers an offense for several mixins in one call' do
expect_offense(<<~RUBY)
class Foo
prepend Bar, Qux
^^^^^^^^^^^^^^^^ Put `prepend` mixins in separate statements.
end
RUBY
expect_correction(<<~RUBY)
class Foo
prepend Qux
prepend Bar
end
RUBY
end
end
context 'when using a mix of diffent methods' do
it 'registers an offense for some calls having several mixins' do
expect_offense(<<~RUBY)
class Foo
include Bar, Baz
^^^^^^^^^^^^^^^^ Put `include` mixins in separate statements.
extend Qux
end
RUBY
expect_correction(<<~RUBY)
class Foo
include Baz
include Bar
extend Qux
end
RUBY
end
end
end
context 'when configured with grouped style' do
let(:cop_config) { { 'EnforcedStyle' => 'grouped' } }
context 'when using include' do
it 'registers an offense for single mixins in separate calls' do
expect_offense(<<~RUBY)
class Foo
include Bar
^^^^^^^^^^^ Put `include` mixins in a single statement.
include Baz
^^^^^^^^^^^ Put `include` mixins in a single statement.
include Qux
^^^^^^^^^^^ Put `include` mixins in a single statement.
end
RUBY
expect_correction(<<~RUBY)
class Foo
include Qux, Baz, Bar
end
RUBY
end
it 'allows include with an explicit receiver' do
expect_no_offenses(<<~RUBY)
config.include Foo
config.include Bar
RUBY
end
it 'registers an offense for several mixins in separate calls' do
expect_offense(<<~RUBY)
class Foo
include Bar, Baz
^^^^^^^^^^^^^^^^ Put `include` mixins in a single statement.
include FooBar, FooBaz
^^^^^^^^^^^^^^^^^^^^^^ Put `include` mixins in a single statement.
include Qux, FooBarBaz
^^^^^^^^^^^^^^^^^^^^^^ Put `include` mixins in a single statement.
end
RUBY
expect_correction(<<~RUBY)
class Foo
include Qux, FooBarBaz, FooBar, FooBaz, Bar, Baz
end
RUBY
end
end
context 'when using `extend`' do
it 'registers an offense for single mixins in separate calls' do
expect_offense(<<~RUBY)
class Foo
extend Bar
^^^^^^^^^^ Put `extend` mixins in a single statement.
extend Baz
^^^^^^^^^^ Put `extend` mixins in a single statement.
end
RUBY
expect_correction(<<~RUBY)
class Foo
extend Baz, Bar
end
RUBY
end
end
context 'when using `prepend`' do
it 'registers an offense for single mixins in separate calls' do
expect_offense(<<~RUBY)
class Foo
prepend Bar
^^^^^^^^^^^ Put `prepend` mixins in a single statement.
prepend Baz
^^^^^^^^^^^ Put `prepend` mixins in a single statement.
end
RUBY
expect_correction(<<~RUBY)
class Foo
prepend Baz, Bar
end
RUBY
end
it 'registers an offense for single mixins in separate calls, interspersed' do
expect_offense(<<~RUBY)
class Foo
prepend Bar
^^^^^^^^^^^ Put `prepend` mixins in a single statement.
prepend Baz
^^^^^^^^^^^ Put `prepend` mixins in a single statement.
do_something_else
prepend Qux
^^^^^^^^^^^ Put `prepend` mixins in a single statement.
end
RUBY
# empty line left by prepend Qux
expect_correction(<<~RUBY)
class Foo
prepend Qux, Baz, Bar
do_something_else
#{trailing_whitespace}
end
RUBY
end
it 'registers an offense when other mixins have receivers' do
expect_offense(<<~RUBY)
class Foo
prepend Bar
^^^^^^^^^^^ Put `prepend` mixins in a single statement.
Other.prepend Baz
do_something_else
prepend Qux
^^^^^^^^^^^ Put `prepend` mixins in a single statement.
end
RUBY
# empty line left by prpend Qux
expect_correction(<<~RUBY)
class Foo
prepend Qux, Bar
Other.prepend Baz
do_something_else
#{trailing_whitespace}
end
RUBY
end
end
context 'when using a mix of diffent methods' do
it 'registers an offense with some duplicated mixin methods' do
expect_offense(<<~RUBY)
class Foo
include Bar
^^^^^^^^^^^ Put `include` mixins in a single statement.
include Baz
^^^^^^^^^^^ Put `include` mixins in a single statement.
extend Baz
end
RUBY
expect_correction(<<~RUBY)
class Foo
include Baz, Bar
extend Baz
end
RUBY
end
it 'allows all different mixin methods' do
expect_no_offenses(<<~RUBY)
class Foo
include Bar
prepend Baz
extend Baz
end
RUBY
end
end
end
end