Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design proposal: Add elevation to symbol layer #62

Open
HarelM opened this issue Mar 19, 2023 · 7 comments
Open

Design proposal: Add elevation to symbol layer #62

HarelM opened this issue Mar 19, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@HarelM
Copy link
Member

HarelM commented Mar 19, 2023

This still needs a bit more refinement, but the general idea is that a symbol layer should be allowed to be presented above the ground, this isn't only for when terrain is on but should also be applied when extrusion is shows to show markers, icons, and text above the ground.

The original request was described here:
maplibre/maplibre-gl-js#644

Since this is somewhat related to 3D visualization I think it can be linked to the following bounty:
maplibre/maplibre#189
Once this is refined and approved we can split this into specific issues and assigned bounties.

@ovivoda
Copy link
Contributor

ovivoda commented Apr 15, 2023

TSC meeting on April 12 notes:

Action points:

  • Please add comments in the above issue and we can discuss this further in the next meeting
  • There’s a need to better define how this would look like in the style-spec, if this is something someone would like to push forward, please do so.

@pietervdvn
Copy link

For MapComplete, this would be really great to have - e.g. if a POI is located at a higher floor (or to do indoor maps).

I see two approaches for this:

  • Include the 'height' in the geojson-coordinates, e.g. {"type": "Point", "location": [51.1,3.1,2]}
  • Define the height as a layout property.

My first instinct is that using the coordinate from the geojson would be the most versatile (but I have not experimented with this)

@lseelenbinder
Copy link
Member

Another potentially use for this is using a raster-dem source to elevate labels (potentially with additional exaggeration) and also render lines from labels -> ground points (extruded or not), similar to how you'd show a mountain range in relief form.

I think limiting this to only GeoJSON sources would be too limiting.

@HarelM
Copy link
Member Author

HarelM commented Apr 25, 2023

In maplibre-gl-js geojson is converted to mvt which doesn't have elevation, so this proposal is less about adding elevation to geometries and more about adding a field in the spec

@cns-solutions-admin
Copy link

cns-solutions-admin commented Aug 18, 2023

Having an attribute would work for points, but it wouldn't for lines. Thus it would be better to support 3D coordinates:

As mapbox currently seems to ignore all 3D point/line issues (e.g. mapbox/vector-tile-spec#111) this could be a major feature of maplibre.

@HarelM
Copy link
Member Author

HarelM commented Aug 18, 2023

We are actively working on the next vector tiles format, but it will take time...
Search for COM and COVTiles.

@HarelM HarelM added the enhancement New feature or request label Dec 31, 2023
@andrewharvey
Copy link

We are actively working on the next vector tiles format, but it will take time...
Search for COM and COVTiles.

Wow didn't know about these, super impressive.

Google wasn't working for me but I did eventually find the repos:

https://github.com/mactrem/com-tiles
https://github.com/mactrem/cov-tiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants