-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design proposal: Support for refreshTiles per tile source #61
Comments
Thanks for taking the time to write this!
While the second point is interesting I think we should focus on the first point. So I would like to try and focus the discussion around the spec, use cases, alternatives etc without getting into implementation details ATM. |
My primary motivation for this change is to improve performance of raster tiles. #1(granularity for refreshing tiles) is the only way I see it can be achieved and it additionally helps with having better control on which set of tiles require refresh. Basically, if a tile source does not need a refresh then we don't care about its cache headers and thus HTMLImageElement can be used. #1 in itself will help
What is the additional input/data required to move forward from here? I have put in 2 options in design proposal. My preference is Option 2, but Option 1 also fine for our scenarios. |
option 1 seems easier. @HarelM what's your suggestion? |
@pramilk since the style specification is independent of MapLibre GL JS in the sense that we also use it in MapLibre GL Native, I think it would be good if you could rewrite the design proposal in such a way that it does not reference javascript or web specific things like |
The idea is cool, we just have to make the motivation a bit more generic such that we know what to do in Native... |
In theory, raster tiles performance improvements can probably be achieved using other "tricks", so I agree with @wipfli, the discussion should be about the spec and be platform independent. |
Sure will update the proposal. |
Sorry for the delay. I have updated proposed design above and have removed any implementation details. Given that this change is also in TileJSON, if everyone is OK with this change, shall I go ahead and propose the changes to TileJON spec? |
We believe the spec to be abandoned in terms of maintenance, we need to understand what are our next steps related to this spec (and probably the mbtiles as well). |
As discussed in the TSC meeting on 12'th of April, the proposal is generally approved Action points:
|
Also from TSC a note from Minh Nguyễn: An API setting could be complementary to something in TileJSON or style JSON. It would allow the MapLibre Navigation SDK to synchronize refreshing of the route data (which includes traffic) and basemap traffic, avoiding user confusion. |
#Updated Proposal
Motivation
Currently map.options provide a property refreshExpiredTiles (default true). This applies to all tile sources.
Not all tile sources need to be refreshed and currently there is no way to override the map.options.refreshExpiredTiles per tileSource. In our use case on Bing maps only Traffic tiles need to be refreshed and no other tiles irrespective of the caching header needs to be refreshed.
Proposed Change
Option 1
Proposal is the have a property refreshExpiredTiles (default: true) which can be set for each tile source. This will allow SDK user more granular control over which tile source need to be refreshed. Tiles which does not require refresh can be downloaded using HTMLImageElement.
This property can be made available for Raster, Raster_dem and Vector source Type. Support for Vector source type is just for consistency.
If user has not provided refreshExpiredTiles override then code will continue to use fetch as done currently.
Option 2
Instead of having a boolean refreshExpiredTiles (Option 1) on tile sources, we can have a property like expiryDuration in seconds. With this all raster tiles can also be downloaded using HTMLImageElement (Both refreshable and non-refreshable raster tiles).
If user has not provided expiryDuration override then code will continue to use fetch as done currently.
API Modifications
Design option 1 with refreshExpiredTiles
Design option 2 with expiryDuration
Migration Plan and Compatibility
Both design options described above adds an optional property and thus are backward compatible.
The text was updated successfully, but these errors were encountered: