Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index-of and slice expression Android 11.0.0 #362

Merged
merged 4 commits into from
May 30, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Oct 2, 2023

Will remove Draft status of this PR once 11.0.0 has been released.

Resolves #159

@HarelM
Copy link
Member

HarelM commented Dec 27, 2023

@louwers any updates on this? Can this be merged?

@louwers
Copy link
Collaborator Author

louwers commented Dec 27, 2023

@HarelM No it is not released yet.

@acalcutt
Copy link
Contributor

Just an FYI, I just made a PR that adds 'slice' and 'index-of' to node also
maplibre/maplibre-native#2047

If this gets merged does the node version need to be added similar to this PR?

@louwers
Copy link
Collaborator Author

louwers commented Jan 23, 2024

@acalcutt We are not currently tracking style support of Node.js. As you can see:

https://maplibre.org/maplibre-style-spec/expressions/

If you want to, you can add it, but you'd have to go over all the other things as well!

@JannikGM
Copy link

JannikGM commented Feb 1, 2024

I didn't see this PR earlier when creating maplibre/maplibre-native#2078 but I believe the style-expression changes should be backported to Android maplibre 10.x, too.

It's not a breaking change, so it makes sense to provide it for Android maplibre 10.x instead of Android maplibre 11.x.
Otherwise apps can't use the new style spec feature before also upgrading to Android 11.x (which is sometimes beyond control of style designers who require slice and index-of and potentially significant work for developers or even impossible for end-users in case system requirements change; e.g. OpenGL ES 3.x).

Backporting them would also make them available immediately; which is probably better than waiting for Android maplibre 11.x to be completed.
Feature was merged in May, unmasking feature [this PR] was planned in October, in December [question above] it still wasn't done.
Feature should have been released already but it's held back by Android maplibre 11.x which should be developed in a separate branch altogether (as Android maplibre 10.x should likely still receive security updates or bugfixes... or non-breaking features) = there shouldn't be any cost in backporting it to Android maplibre 10.x.

@HarelM
Copy link
Member

HarelM commented Mar 7, 2024

@louwers this is a reminder since I saw you are creating apre release of 11.

@JannikGM
Copy link

JannikGM commented Mar 7, 2024

I didn't even remember this PR; it should be changed to 10.3.x after maplibre/maplibre-native#2135 (which should have been released already)

@louwers
Copy link
Collaborator Author

louwers commented Mar 7, 2024

There's no official release out with these features.

@HarelM
Copy link
Member

HarelM commented Apr 3, 2024

@louwers didn't you release version 11?

@louwers louwers marked this pull request as ready for review May 30, 2024 11:33
src/reference/v8.json Outdated Show resolved Hide resolved
src/reference/v8.json Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (bab15e3) to head (0e97811).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files         104      104           
  Lines        4616     4616           
  Branches     1301     1301           
=======================================
  Hits         4273     4273           
  Misses        343      343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 36a82b2 into maplibre:main May 30, 2024
6 checks passed
@louwers louwers deleted the android-11.0.0 branch May 30, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapLibre Native support for index-of
5 participants