You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am using LocalStack for a local S3 for verification, integration tests etc., so I am using localhost and other domains not part of the normal production AWS forms.
I have followed the configuration instructions here and publishing works perfectly, but the hosted_path property in the lib/utils/versioning.js doesn't take this parameter into account (we can see in the PR that introduces the s3ForcePathStyle parameter that the evaluate method in versioning.js accepts the parameter, but never uses it.)
I believe the opts.hosted_path needs to be altered to account for the bucket name being part of the path so that installation may also occur from a non-standard AWS path.
and an S3 bucket available at https://localhost.localstack.cloud:4566/my-packages an invocation of node-pre-gyp publish will place the tarball correctly in https://localhost.localstack.cloud:4566/my-packages/npm/my-module/addon/my-module.tar.gz, but an invocation of node-pre-gyp install will try to download the tarball from https://localhost.localstack.cloud:4566/npm/my-module/addon/my-module.tar.gz - notably without the bucket in the path.
The text was updated successfully, but these errors were encountered:
jared-duo
added a commit
to jared-duo/node-pre-gyp
that referenced
this issue
Sep 22, 2021
I am using LocalStack for a local S3 for verification, integration tests etc., so I am using
localhost
and other domains not part of the normal production AWS forms.I have followed the configuration instructions here and publishing works perfectly, but the
hosted_path
property in thelib/utils/versioning.js
doesn't take this parameter into account (we can see in the PR that introduces thes3ForcePathStyle
parameter that theevaluate
method inversioning.js
accepts the parameter, but never uses it.)I believe the
opts.hosted_path
needs to be altered to account for the bucket name being part of the path so that installation may also occur from a non-standard AWS path.Example:
Given a
package.json
and an S3 bucket available at
https://localhost.localstack.cloud:4566/my-packages
an invocation ofnode-pre-gyp publish
will place the tarball correctly inhttps://localhost.localstack.cloud:4566/my-packages/npm/my-module/addon/my-module.tar.gz
, but an invocation ofnode-pre-gyp install
will try to download the tarball fromhttps://localhost.localstack.cloud:4566/npm/my-module/addon/my-module.tar.gz
- notably without the bucket in the path.The text was updated successfully, but these errors were encountered: