fix albers edge cases and lambert center #11229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The albers implementation was not solid. Switch to one based on d3-geo (thanks!) which is much more robust. Lambert was not using the center longitude.
1 task
ryanhamley
approved these changes
Nov 5, 2021
|
@ansis I added a commit that brings back the Albers wrapping correction in the new implementation (plus a minor cleanup). Without it, this happens: Screen.Recording.2021-11-05.at.08.56.12.mov |
mourner
approved these changes
Nov 5, 2021
ansis
added a commit
that referenced
this pull request
Nov 5, 2021
* fix albers edge cases and lambert center The albers implementation was not solid. Switch to one based on d3-geo (thanks!) which is much more robust. Lambert was not using the center longitude. * bring back albers wrap correction Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
SnailBones
pushed a commit
that referenced
this pull request
Nov 5, 2021
* fix albers edge cases and lambert center The albers implementation was not solid. Switch to one based on d3-geo (thanks!) which is much more robust. Lambert was not using the center longitude. * bring back albers wrap correction Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11228
The albers implementation was not solid. If the parallels were negative enough unproject would return an incorrect value. Some other situations would return NaN. Switch to one based on d3-geo (thanks!) which is much more robust.
Lambert was not using the center longitude. Now it does.
Cylindrical equal area is not meaningful for [-90, 90]. I added a min value to avoid errors elsewhere.
Launch Checklist