Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render tests for map projections #11208

Merged
merged 6 commits into from Nov 4, 2021
Merged

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

  • briefly describe the changes in this PR
    • adds render tests for:
      • vector, raster, z0, z3, z10 and configured (center/parallels for conic projections) for all projections
      • background-pattern (ignored)
      • canvas
      • circle-radius
      • fill-pattern (ignored)
      • heatmap-radius
      • image and wrapped image
      • line-width
      • text-size
      • video
  • write tests for all new functionality
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'

@ryanhamley ryanhamley added the skip changelog Used for PRs that do not need a changelog entry label Nov 3, 2021
@ryanhamley ryanhamley requested a review from ansis November 3, 2021 01:19
@ryanhamley ryanhamley self-assigned this Nov 3, 2021
@ryanhamley
Copy link
Contributor Author

The raster and video tests seem to be failing because of small pixel differences. I'm not sure why since they pass locally. I'm guessing this may be due to different devices calculating the pixels slightly different during reprojection. Is the best approach to this to add a pixel tolerance to these tests or should we try to make it more determinant?

@karimnaaji
Copy link
Contributor

karimnaaji commented Nov 4, 2021

Is the best approach to this to add a pixel tolerance to these tests or should we try to make it more determinant?

Looking at the render tests I think so. I might need this PR merged soon to be able to do a sane rebase from main to globe-view, there will be a lot of conflicts that would be hard to reason about without the validation of render tests.

Copy link
Contributor

@ansis ansis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so great. Really thorough

@ryanhamley ryanhamley merged commit dd03953 into main Nov 4, 2021
@ryanhamley ryanhamley deleted the projections-render-tests branch November 4, 2021 22:23
ansis pushed a commit that referenced this pull request Nov 5, 2021
SnailBones pushed a commit that referenced this pull request Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants