New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add render tests for map projections #11208
Conversation
The raster and video tests seem to be failing because of small pixel differences. I'm not sure why since they pass locally. I'm guessing this may be due to different devices calculating the pixels slightly different during reprojection. Is the best approach to this to add a pixel tolerance to these tests or should we try to make it more determinant? |
Looking at the render tests I think so. I might need this PR merged soon to be able to do a sane rebase from |
5682465
to
7243163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so great. Really thorough
Launch Checklist