Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.13.2 release tests #11104

Merged
merged 4 commits into from
Oct 7, 2021
Merged

Conversation

rreusser
Copy link
Contributor

@rreusser rreusser commented Oct 7, 2021

Attempt to fix release tests by amending url pattern to point to public examples.

@rreusser rreusser requested a review from avpeery October 7, 2021 21:37
@rreusser rreusser changed the title Fix release test url pattern Fix 1.13.2 release test url pattern Oct 7, 2021
@rreusser rreusser changed the title Fix 1.13.2 release test url pattern Fix 1.13.2 release tests Oct 7, 2021
Copy link
Contributor

@avpeery avpeery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if tests pass, LGTM - I am wondering if we shouldn't add the tests image-on-a-map and locate-the-user if they weren't previously there yet?

@rreusser rreusser merged commit 18ec8ff into release-v1.13.2 Oct 7, 2021
@rreusser rreusser deleted the ricky/fix-1.13.2-release-tests branch October 7, 2021 22:28
@rreusser
Copy link
Contributor Author

rreusser commented Oct 7, 2021

Ah, good point. I just glanced through and removed whatever didn't work, though you may be right. worst case, we can just ignore what doesn't work. 👍

@rreusser
Copy link
Contributor Author

rreusser commented Oct 7, 2021

(I didn't even look at the diff, just copied the entire release-test dir and it seemed to work 🤷 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants