Update sources and markers while fog transitioning #10691
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreusser
added
bug 🐞
skip changelog
karimnaaji
reviewed
May 20, 2021
There was a problem hiding this comment.
The change looks good to me, nice find! Just some minor suggestion.
These type of fixes should directly target the main branch so we're sure to not forget about them. Could you cherry-pick this change + #10679 to merge back in main?
Is there any reasonable way we could unit test that? e.g. confirm that a transition results in a fog update.
karimnaaji
approved these changes
May 21, 2021
rreusser
added a commit
that referenced
this pull request
May 21, 2021
* Update sources while fog transitioning * Apply fix to markers * Remove unnecessary comment
rreusser
added a commit
that referenced
this pull request
May 28, 2021
* Update sources while fog transitioning * Apply fix to markers * Remove unnecessary comment
karimnaaji
pushed a commit
that referenced
this pull request
Jun 1, 2021
* Implement dual ESM + CJS compatibility in style-spec (#10718) * Implement dual ESM + CJS compatibility in style-spec * Try to catch additional references to non-cjs files * Remove accidentally-committed files * Revert main entry point * Revert module field as well * Update sources and markers while fog transitioning (#10691) * Update sources while fog transitioning * Apply fix to markers * Remove unnecessary comment * Include dist/package.json in npm published files (#10668) * Disable fog tile culling with low horizon-blend (#10679) * Cherry-pick changelogs
SnailBones
pushed a commit
to SnailBones/mapbox-gl-js
that referenced
this pull request
Jul 15, 2021
* Implement dual ESM + CJS compatibility in style-spec (mapbox#10718) * Implement dual ESM + CJS compatibility in style-spec * Try to catch additional references to non-cjs files * Remove accidentally-committed files * Revert main entry point * Revert module field as well * Update sources and markers while fog transitioning (mapbox#10691) * Update sources while fog transitioning * Apply fix to markers * Remove unnecessary comment * Include dist/package.json in npm published files (mapbox#10668) * Disable fog tile culling with low horizon-blend (mapbox#10679) * Cherry-pick changelogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10686
Since fog affects tile culling and marker appearance, this PR checks whether fog is transitioning and updates sources and markers during the transition.
Before this fix (tiles do not load and marker reflects state at the start of the transition rather than during or after it):
After this fix (marker and sources update during transition):
Note:
_updateFog()alone was not adequate to solve the problem since even if it computes an updated tile culling threshold, it does not apply it.Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes@mapbox/gl-nativeif this PR includes shader changes or needs a native portmapbox-gl-jschangelog:<changelog></changelog>