[@mantine/core] fix: ensure TagsInput dropdown reopens after clearing #6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Resolve the issue where the TagsInput dropdown would not reopen after clearing tags.
This PR addresses the issue where the dropdown of the TagsInput component fails to reopen after the user clicks the clear button and subsequently attempts to interact with the input again.
Problem:
The dropdown, after tags are cleared via the clear button, remains closed upon subsequent interactions unless clicked outside and back again. This behavior was consistent across all browsers and was problematic from a UX perspective.
Solution:
A modification was made to the
PillsInputcomponent's click event logic. Now, the dropdown checks if there are any items in theparsedDataarray (ensuring there are actionable items) before deciding to open. This change ensures that the dropdown reopens as expected when there are items available to display, thus improving the component's usability.fixes #6115
commit: 3a43d08