Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally enable / disable no-null based on presence of graphql #154

Closed
manovotny opened this issue Mar 24, 2021 · 1 comment
Closed

Comments

@manovotny
Copy link
Owner

manovotny commented Mar 24, 2021

The unicorn/no-null rule was added in v6, and while it is the idyllic state, it does appear to complete / conflict with GraphQL standards / best practices. To the point that even if you pass undefined to GraphQL, it’ll coerce it to null anyway.

To that end, we should check for the presence of graphql in dependencies and conditionally disable this rule.

Might be worth waiting until #37 too.

@manovotny
Copy link
Owner Author

This will be fixed in the v7 release.

@manovotny manovotny mentioned this issue Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant