Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird http pooling related error after v0.6.patch upgrade #81

Closed
izelnakri opened this issue Dec 7, 2020 · 1 comment
Closed

Weird http pooling related error after v0.6.patch upgrade #81

izelnakri opened this issue Dec 7, 2020 · 1 comment

Comments

@izelnakri
Copy link
Collaborator

izelnakri commented Dec 7, 2020

Hi there,

After upgrading ethereumex from v0.6.0 to v0.6.1 my test suite fails/gets stuck with some odd error. After some debugging I find error to be a very implicit/fundamental change in the way http pool is handled due to internal httpoison upgrade:

https://github.com/izelnakri/eth/blob/master/test/support/eth_client.exs#L13
https://github.com/izelnakri/eth/blob/master/test/support/eth_client.exs#L42 -> following code first returns hundreds/thousands of {:error, :econnrefused} while waiting for the spawned processes/ganache-cli http server to start and then it subsequent requests dont seem to get sent, and I assume the previous ones on the pool now returns {:error, :checkout_timeout} after ganache-cli starts serving the requests.

I'm still digging to see what has changed, the test suite doesnt work on the latest ethereumex as well. Most likely, our http pooling logic has changed and needs adjustments. I'll share more information once I have better understanding.

More info on the {:error, :checkout_timeout}: edgurgel/httpoison#359

@ayrat555
Copy link
Member

ayrat555 commented Dec 27, 2020

Your pr was merged and httpoison was bumped to 1.7 in 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants