Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates #88

Merged
merged 5 commits into from Aug 4, 2022
Merged

Readme updates #88

merged 5 commits into from Aug 4, 2022

Conversation

zmoon
Copy link
Contributor

@zmoon zmoon commented Aug 4, 2022

I wanted to add a note about the #54 upshot to the parameter descriptions. Also tried to make some things easier to read (IMO) in the readme by adding some more Markdown styling.

@jonashaag
Copy link
Collaborator

Thanks for the PR.

I think it is harder to read now. Maybe we can use italics like the Python docs?

@zmoon
Copy link
Contributor Author

zmoon commented Aug 4, 2022

That's a good idea. Like italics when referring to parameters that are in the parameter list? That is a common rST style. Do you have a preference between _ and * for Markdown italic?

@jonashaag
Copy link
Collaborator

Yes and no :)

@jonashaag
Copy link
Collaborator

Awesome thanks, do you consider this ready to be merged?

@zmoon
Copy link
Contributor Author

zmoon commented Aug 4, 2022

I also just thought to update the actions versions in the examples (e.g. actions/checkout to v3). Would you want provision-with-micromamba left as main? The caching examples would work with v12. If not interested in this I think it is fine to merge now.

@jonashaag
Copy link
Collaborator

Yes let's keep main but a new PR with the updates is welcome :) Also if you are looking to contribute even more let me know :-D

@jonashaag jonashaag merged commit a319a81 into mamba-org:main Aug 4, 2022
@zmoon zmoon deleted the readme branch August 4, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants