Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ES6 Modules #35

Closed
austingardner opened this issue Jun 2, 2021 · 5 comments · Fixed by #60
Closed

Support ES6 Modules #35

austingardner opened this issue Jun 2, 2021 · 5 comments · Fixed by #60
Assignees
@ianmcburnie

Comments

@austingardner
Copy link
Contributor

With the deprecation of IE11, it is now time to move the makeup-js repo over to ES6 modules.
@ianmcburnie
Copy link
Member

We can probably divide this work in two, and both work from the same branch. We can tackle #33 at the same time.

@austingardner
Copy link
Contributor Author

austingardner commented Jun 7, 2021 •
edited

Okay sounds good to me! Which packages do you want?

@ianmcburnie
Copy link
Member

ianmcburnie commented Jun 8, 2021 •
edited

This could be relevant:

https://twitter.com/Rich_Harris/status/1361819156648189954

d3/d3#3469

@ianmcburnie
Copy link
Member

ianmcburnie commented Aug 3, 2021 •
edited

This is blocked until we figure out how to support Lasso as well.

@ianmcburnie ianmcburnie changed the title Convert to ES6 Modules Support ES6 Modules Dec 2, 2021
@ianmcburnie
Copy link
Member

ianmcburnie commented Dec 2, 2021 •
edited

Unblocked via the exports field in package.json and ESBuild

ianmcburnie added a commit that referenced this issue Dec 8, 2021
@ianmcburnie
feat: support ESM and CJS (1st draft) #35
5643597
@ianmcburnie ianmcburnie mentioned this issue Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianmcburnie ianmcburnie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Support ESM (maintaining support for CJS) makeup/makeup-js
2 participants
@ianmcburnie @austingardner