Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the Layout/RescueEnsureAlignment Cop #16

Closed
makmic opened this issue Feb 11, 2020 · 2 comments
Closed

Disable the Layout/RescueEnsureAlignment Cop #16

makmic opened this issue Feb 11, 2020 · 2 comments

Comments

@makmic
Copy link
Member

makmic commented Feb 11, 2020

There are multiple scenarios where the Layout/RescueEnsureAlignment cop urges me to align my ensure block in an ugly way. I vote to disable the cop for our makandra fork.

Examples

  • For variable assignments, the cop tries to align the ensure block with the do keyword.
my_block = do
  # do stuff
ensure
  # other stuff
end
  • For memoized method, the cop tries to align the ensure block with the def keyword.
memoized def foo
  # do stuff
ensure
  # other stuff
end
@denzelem
Copy link
Collaborator

So this is a bug in Rubocop (maybe related to rubocop/rubocop#7531 or rubocop/rubocop#7470) and we want to temporary disable it until it's fixed in the upstream?

@denzelem
Copy link
Collaborator

This was a regression of #7, we disabled the cop again until it is really fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants