From c4fdde9e6cb2cb83a3d618ab768efccb93241d4e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Kowalik?= <maf.michal@gmail.com>
Date: Tue, 19 Mar 2019 00:30:48 +0100
Subject: [PATCH] #654 remove functions that cannot be easily mapped

---
 src/Mutator/Extensions/MBString.php       |  2 --
 tests/Mutator/Extensions/MBStringTest.php | 35 -----------------------
 2 files changed, 37 deletions(-)

diff --git a/src/Mutator/Extensions/MBString.php b/src/Mutator/Extensions/MBString.php
index a7b51e4f5..d332870b1 100644
--- a/src/Mutator/Extensions/MBString.php
+++ b/src/Mutator/Extensions/MBString.php
@@ -87,14 +87,12 @@ private function setupConverters(array $functionsMap): void
             'mb_ord' => $this->mapNameSkipArg('ord', 1),
             'mb_parse_str' => $this->mapName('parse_str'),
             'mb_send_mail' => $this->mapName('mail'),
-            'mb_split' => $this->mapName('split'),
             'mb_strcut' => $this->mapNameSkipArg('substr', 3),
             'mb_stripos' => $this->mapNameSkipArg('stripos', 3),
             'mb_stristr' => $this->mapNameSkipArg('stristr', 3),
             'mb_strlen' => $this->mapNameSkipArg('strlen', 1),
             'mb_strpos' => $this->mapNameSkipArg('strpos', 3),
             'mb_strrchr' => $this->mapNameSkipArg('strrchr', 2),
-            'mb_strrichr' => $this->mapNameSkipArg('strrchr', 2),
             'mb_strripos' => $this->mapNameSkipArg('strripos', 3),
             'mb_strrpos' => $this->mapNameSkipArg('strrpos', 3),
             'mb_strstr' => $this->mapNameSkipArg('strstr', 3),
diff --git a/tests/Mutator/Extensions/MBStringTest.php b/tests/Mutator/Extensions/MBStringTest.php
index 14ed4e064..5f2deb203 100644
--- a/tests/Mutator/Extensions/MBStringTest.php
+++ b/tests/Mutator/Extensions/MBStringTest.php
@@ -87,8 +87,6 @@ public function provideMutationCases(): Generator
 
         yield from $this->provideMutationCasesForSendMail();
 
-        yield from $this->provideMutationCasesForSplit();
-
         yield from $this->provideMutationCasesForStrCut();
 
         yield from $this->provideMutationCasesForStrPos();
@@ -113,8 +111,6 @@ public function provideMutationCases(): Generator
 
         yield from $this->provideMutationCasesForStrRChr();
 
-        yield from $this->provideMutationCasesForStrRiChr();
-
         yield from $this->provideMutationCasesForConvertCase();
     }
 
@@ -170,19 +166,6 @@ private function provideMutationCasesForSendMail(): Generator
         ];
     }
 
-    private function provideMutationCasesForSplit(): Generator
-    {
-        yield 'It converts mb_split to split' => [
-            "<?php mb_split('to', 'subject');",
-            "<?php\n\nsplit('to', 'subject');",
-        ];
-
-        yield 'It converts mb_split with limit parameter to split' => [
-            "<?php mb_split('to', 'subject', 2);",
-            "<?php\n\nsplit('to', 'subject', 2);",
-        ];
-    }
-
     private function provideMutationCasesForStrCut(): Generator
     {
         yield 'It converts mb_strcut to substr' => [
@@ -384,24 +367,6 @@ private function provideMutationCasesForStrRChr(): Generator
         ];
     }
 
-    private function provideMutationCasesForStrRiChr(): Generator
-    {
-        yield 'It converts mb_strrichr to strrchr' => [
-            "<?php mb_strrichr('subject', 'b');",
-            "<?php\n\nstrrchr('subject', 'b');",
-        ];
-
-        yield 'It converts mb_strrichr with part argument to strrchr' => [
-            "<?php mb_strrichr('subject', 'b', false);",
-            "<?php\n\nstrrchr('subject', 'b');",
-        ];
-
-        yield 'It converts mb_strrichr with encoding to strrchr' => [
-            "<?php mb_strrichr('subject', 'b', false, 'utf-8');",
-            "<?php\n\nstrrchr('subject', 'b');",
-        ];
-    }
-
     private function provideMutationCasesForConvertCase(): Generator
     {
         yield 'It converts mb_convert_case with MB_CASE_UPPER mode to strtoupper' => [