Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush changes at the end of Modificator #887

Open
aslakknutsen opened this issue Sep 3, 2021 · 0 comments
Open

Flush changes at the end of Modificator #887

aslakknutsen opened this issue Sep 3, 2021 · 0 comments
Labels
component/operator Component: Operator service kind/enhancement Kind: New feature or improvement

Comments

@aslakknutsen
Copy link
Member

aslakknutsen commented Sep 3, 2021

What can be improved

In the situation where a Ref is updated in a session the Locators will create two actions for most Resources, DELETE/REVERT and CREATE/MODIFY. This will trigger in the current setup a sequence of events:

read - revert - save - read - modify - save

In a lot of the cases like VirtualService, Gateway and DestinationRule this will recreate the exact same output. That means we could detect that both 'create' and 'delete' will happen to the same resource and likely to get away with a sequence of events like:

read - (revert - modify) - save?

Why

This will lower the amount of calls required to the API server and config flushes needed by istiod.

There is a slight chance that this will also fix a strange race like condition observed on the Brno cluster.

@aslakknutsen aslakknutsen added kind/enhancement Kind: New feature or improvement component/operator Component: Operator service labels Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operator Component: Operator service kind/enhancement Kind: New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant