Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: favor ctx passing instead of keeping field in struct #1100

Open
bartoszmajsak opened this issue Oct 27, 2022 · 0 comments
Open

refactor: favor ctx passing instead of keeping field in struct #1100

bartoszmajsak opened this issue Oct 27, 2022 · 0 comments
Labels
kind/enhancement Kind: New feature or improvement

Comments

@bartoszmajsak
Copy link
Contributor

What can be improved

type SessionContext struct {
context.Context
Name string
Namespace string
Route Route
Client client.Client
Log logr.Logger
}

https://go.dev/blog/context-and-structs

Why

It's considered confusing and discouraged by golang team.

@bartoszmajsak bartoszmajsak added the kind/enhancement Kind: New feature or improvement label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Kind: New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant