Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZSH completion tests #1045

Open
bartoszmajsak opened this issue Jul 20, 2022 · 0 comments
Open

ZSH completion tests #1045

bartoszmajsak opened this issue Jul 20, 2022 · 0 comments
Labels
component/cli Component: CLI tooling good first issue First time contributor friendly issue internal/test-infra Internal: related to project testing kind/enhancement Kind: New feature or improvement

Comments

@bartoszmajsak
Copy link
Contributor

What can be improved

Similarly to bash completion tests we should verify if our logic works under zsh too. We might be able to use a similar technique as in bash_completion_test.go by using https://github.com/Valodim/zsh-capture-completion.

Why

To ensure we are shipping a working completion for zsh.
@bartoszmajsak bartoszmajsak added kind/enhancement Kind: New feature or improvement component/cli Component: CLI tooling internal/test-infra Internal: related to project testing good first issue First time contributor friendly issue labels Jul 20, 2022
@bartoszmajsak bartoszmajsak mentioned this issue Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/cli Component: CLI tooling good first issue First time contributor friendly issue internal/test-infra Internal: related to project testing kind/enhancement Kind: New feature or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartoszmajsak