Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle type definitions along with the npm package #445

Open
illright opened this issue Jan 19, 2023 · 2 comments
Open

Bundle type definitions along with the npm package #445

illright opened this issue Jan 19, 2023 · 2 comments

Comments

@illright
Copy link

This package has type definitions in DefinitelyTyped, however, I think it might be more convenient to add the .d.ts. file to this repository to make updates to the API easier and remove the requirement for users to install additional typings for this package.

Would you be open to a pull request to add the type definitions here?
@Progi1984
Copy link

Progi1984 commented Feb 16, 2023 •
edited

Great idea @illright. I have the same need. Interested and available for contributing.

Are you interested @maildev / @djfarrelly / @soulteary?

@Progi1984 Progi1984 mentioned this issue Feb 16, 2023
Merged
@Progi1984 Progi1984 mentioned this issue Mar 3, 2023
Closed
@Progi1984
Copy link

I open a PR #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add declaration for Maildev
2 participants
@Progi1984 @illright