-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I've created a fork with improvements & PR merges #335
Comments
Hey @DominikSerafin, I have to admit that I no longer have the proper time to commit to this project and I completely agree with you that it's better to merge into this project rather than create a fork. From a quick overview, I like what you've done. How would you suggest we incorporate your changes? I see you've made some additional changes that I think would be good to not make in this upstream repo (e.g. README changes, removal of files like code climate). |
Hello, A dark mode will be at least a great addition. |
@djfarrelly happy to hear that! When I'll have some more free time (hopefully soon) I'll work on creating PR with only a subset of changes from my fork (without changes to code climate, README, etc.) and with full changelog attached. @kl3sk #154 is somewhat "fixed" in my fork, e.g. when there are 3 recipients, the sidebar item shows |
Glad to here that. Is there a docker image of your fork. I'm interested in trying it and why not using it. Unless @djfarrelly decide to use some or all your features. Thanks |
Hey @DominikSerafin, after reviewing your work in the fork, I've given you write access to this repo. I know that it may take several PRs and some may need to be merged in a specific order. I wanted to allow you to move ahead without me or anyone else blocking you from getting your improvements into master. If you need me to push docker images or publish to NPM, please let me know!! Also, if it helps longer term, we could set up Github actions with my tokens to push to Docker hub and npm (maybe Github packages too?). That could allow you or others to ship new functionality faster. |
After testing @DominikSerafin fork. I can said it works without any issues for me. |
@djfarrelly amazing, it will for sure make the process smoother. Thank you! As for Docker/NPM - it would of course help even more, but for now, I think it will suffice that I can just ping you whenever there will be any code ready for release. |
thanks all, this looks great! having these changes on npm would certainly be welcomed for users (like me) as well :) |
Status update - almost finished with introducing the changes to this repo. Should have finishing touches done hopefully soon. |
awesome, looking forward to a new release! thanks for your work, very much appreciated! |
Hey @djfarrelly I've introduced everything from my fork (with exception to the cleanups I did, like e.g. Codecov deletion). On top of that, I've:
If you don't spot any new issues introduced by my changes I think we could release now the new MailDev version. Once that is up, I'll archive my fork. |
Fantastic addons in the fork! Any update on the status of releasing a new version here? |
Hi @DominikSerafin , Have you made any new releases for this repo ? |
@a-h-abid I only have collaborator access to commit code to this repo. I'm unable to release a new version to npm/Docker. |
@DominikSerafin you said that #154 was fixed at least. And it is. But could you consider an option to not group them ? |
Hi @djfarrelly, do you see any chance to give more permissions to @DominikSerafin? It's very sad to see this great project dying... |
@kl3sk I don't plan to do any more work or maintenance on maildev any time soon. So, @thirsch, with that in mind, I don't need any additional permissions or access if @djfarrelly could publish the recent changes as a new release on npm/Docker. |
Hello @djfarrelly , The Open Government Products group in Singapore (@opengovsg) are regular users of maildev and would like to assume responsibilities to maintain this repository and publish changes to npm and Docker Hub. The specific individuals that we hope you would grant relevant access to are: @LoneRifle (myself) Echoing @thirsch , we would be likewise a little sad if the work done by @DominikSerafin and others is in vain, and would like to continue stewardship of this package that you have created. We also have a fork that we can fall back on for our own needs, but would love the opportunity to keep the canonical package going. |
@djfarrelly Could you give people mentioned by @LoneRifle access so that they can maintain the project and upload new Docker images? |
Their fork was archived. |
@LoneRifle does that mean you have permissions for this repo now? If yes, could you upload a new Docker image? |
I would be happy if someone would take on this project and develop it further. :) |
@DominikSerafin Hi 👋, It looks like we did two forks. I'm thinking of fully containerizing this project with web hooks, maybe in the near future I can replace maildev src with your project. my repo: https://github.com/soulteary/maildev |
would be nice if one of the forks could also push their updated code to the npm repository (https://www.npmjs.com/search?q=maildev) for the end users :) |
I've ported a new feature I added to our fork and filed a PR against your repo. Hope you get round to reviewing it soon! |
@LoneRifle @soulteary (and all) - I apologize for not being able to maintain this properly. I've had some false starts with re-invigorating the project and great folks like @DominikSerafin have offered to help and indeed have contributed, we haven't been able to maintain momentum. I am happy to give access to folks that are maintaining forks and would be ok with helping merge PRs and push updated packages and images. @LoneRifle and @soulteary - if I gave you two access would you be up to collaborate on updating the main repo with the improvements in your forks? |
Sorry for the late reply, I just saw your message when I was just cleaning up my unread messages. @djfarrelly I'd love to be part of every community, sharing and perfecting the good stuff. 🍻 The current project does lack a small virtual team for maintenance and management, so if several people can maintain it together, it should be the best choice for the project. But I'm not sure how this small team will maintain relatively smooth communication next, and relying solely on GitHub reminders will not be timely. If you want to quickly change the status of the project, perhaps the most direct way is to quickly reach an agreement with a small team, confirm what the project will not do next, reply to users clearly, and maintain a relatively healthy continuous update and release. I am currently using a software called lark (similar to slack) at work, which can maintain relatively fast communication with overseas colleagues, as well as leave messages offline. I don't know if you guys will like this. I would love to hear other people's views and suggestions. |
I wouldn't mind. Having the ability to publish the nom package would be helpful too! |
@LoneRifle @soulteary @DominikSerafin - I have invited you each to the Maildev Github organization team called "Contributors." While I think a real-time communication tool like Lark or Slack could work, I think the real-time nature and various working time zones may make that difficult. Github teams have built in message boards which can allow us to have discussions on what to do next and help coordinate the project outside of the confines of a pull request or an issue. I think this could be a good for us to coordinate on. If others want to support the project or join in discussions, we can bring them in over time. Here's a direct link to the group message board that I invited you all to: https://github.com/orgs/maildev/teams/contributors/discussions I'll kick off a couple threads to get started, but feel free to open your own discussion if you want to discuss or ask about something specifically, e.g. npm publish access. Thanks for your interest!! |
@djfarrelly thanks for the invite! @soulteary - I'm leaving it to you to file the PR from your fork to merge our changes back into this repo. |
Any updates on this? |
Most of these changes have been merged and were released as part of the 2.0 release in May 2022. See: https://github.com/maildev/maildev/releases I'm going to close this and if there is a specific change that is requested, we should open a separate issue or PR. |
Hey all — I've created a fork of this project with various improvements and also some PR merges. You can check it out at https://github.com/DominikSerafin/maildev.
I've created my own fork because this project seems abandoned, and I wanted some of the features that were not implemented (mostly persistent storage and some web interface fixes/polishes).
However, @djfarrelly @oktapodia if you're still maintaining this repo and are open to merging changes from my fork — let me know, and I'll open PR. I'd prefer not to fragment this project.
Screenshots of the refreshed web interface:
The text was updated successfully, but these errors were encountered: